[Zlib-devel] [PATCH Take 2] 1.2.3 makefile.msc usability & rc fix (too late)

[William A. Rowe, Jr.]

William A. Rowe, Jr. wrote:
> 
> Taking into account Cosmin's feedback and Andrei's valid points, attached
> is the obvious patch.

Sorry, with this patch -wd4996 should -not- have appeared.

Retested with VisualStudio 2005, including the free Express edition,
Visual Studio 2003, VisualStudio .NET (2002), and 6.0, with this flag omitted.

With the same compilers, I have also tested contrib/masmx86/... with -Zi added
to ASFLAGS, and the attached patch applied to resolve the pointer dereference
field size flaw, and all looked well.

I finally tested vanilla as well as the contrib/masmx64 (again, -Zi in ASFLAGS)
Visual Studio 2005 x64 environment flavors, as per the the patch to the notes,
attached, and again all looked well for both vanilla and masmx64 builds.

To clear up all confusion, the -make patch is also attached.  These two patches,
plus the earlier -rcver-floating.patch from today, and my zlib123-solaris.patch
reposted on 5/1 and reviewed by Cosmin, are my completed recommendations for
the next 1.2.x release, based on everyone's feedback and fixing my fat fingers.

Respectfully,

Bill
-------------- next part --------------
A non-text attachment was scrubbed...
Name: zlib-1.2.3-vc32-2005-asm.patch
Type: text/x-patch
Size: 1477 bytes
Desc: not available
URL: <http://madler.net/pipermail/zlib-devel_madler.net/attachments/20060503/e2e9a8cd/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: zlib-1.2.3-vc32-2005-make.patch
Type: text/x-patch
Size: 1760 bytes
Desc: not available
URL: <http://madler.net/pipermail/zlib-devel_madler.net/attachments/20060503/e2e9a8cd/attachment-0001.bin>