[Zlib-devel] [PATCH Take 2] 1.2.3 makefile.msc usability & rc fix (too late)

[Cosmin Truta]

Sorry, William, for not being able to reply earier.
You did point out valid issues, to which I will respond.

William A. Rowe, Jr. wrote:

> > But why do you generate .pdb files,
>
> Because some of us actually have to support the user who's app is
> crashing, no matter what nice "no warrenty" clause is attached to
> zlib's license ;-)

Acknowledged. I hope that, in zlib-1.2.3-cos1, the pdb file is created
as you intended.

> > and why are you slowing the DLL down in order to enable stack
> > backtrace?
>
> Because I personally believe in sound stackframes, strongly object to
> bastardizing the architecture to get at the last ounce of performance,
> and because, programs crash :)

I thought that Visual C++ can backtrace through optimized stack frames.
(AFAIK gcc+gdb can!)

> With zlib/openssl/httpd, in one case, I uncover nested bugs in one lib
> that are apropos of nothing in those sources, it's garbage in-garbage
> out, and need to get back to the source which sent up the garbage.
> Not in debug/development time, but in the real world.

I didn't know that, sorry.
It seems to me that you are using zlib1.dll for real, and you know well
enough what's good and what's not. Is httpd compiled with stack frames,
too?

> I've removed -Oy- based on Cosmin's strong negative reaction

Oh no! I only asked "why generate pdb's" and "why not optimize stack
frames"! Check my quotes above ;-)

Cosmin