[Zlib-devel] [PATCH Take 2] 1.2.3 makefile.msc usability & rc fix (too late)

[William A. Rowe, Jr.]

[This time, with attach]

Taking into account Cosmin's feedback and Andrei's valid points, attached
is the obvious patch.  I've removed -Oy- based on Cosmin's strong negative
reaction, retained the .pdb that software professionals won't live without,
and simplified the clean: phase so only existing files are deleted without
any fnf noise.

I never explained why I suggested changing FILEOS in the .rc file, however.
This is a WINDOWS32 binary, that we agree on.  But this is not targetted,
and does not depend on either a MS-DOS based subsystem or ntdll subsystem,
so some conventions say to keep mute on advertising either.

Please consider this patch as-is.  Tested on VC 6.0 and 2005.

Bill

William A. Rowe, Jr. wrote:
> Andrei Polushin wrote:
> 
>>
>>Those changes in zconf.h will disable the "deprecation warning" even in
>>non-zlib code, and that looks like a side effect.
> 
> 
> That's an interesting point.  Maybe zutil.h is a better place for this change?
> However, the -D's would be required for those sources which include zlib.h,
> and those which include <stdio.h>/<stdarg.h> before zutil.h or deflate.h would
> need to be rearranged, to use cosmin's fix.
> 
> _______________________________________________
> Zlib-devel mailing list
> Zlib-devel at zlib.net
> http://madler.net/mailman/listinfo/zlib-devel_madler.net
> 
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: zlib-1.2.3-vc32-2005-rcver.patch
Type: text/x-patch
Size: 2270 bytes
Desc: not available
URL: <http://madler.net/pipermail/zlib-devel_madler.net/attachments/20060503/0378cc81/attachment.bin>