[Zlib-devel] [RFC][PATCH] fix parallel make issue

Enrico Weigelt weigelt at metux.de
Fri Feb 4 06:38:41 EST 2011


* Daniel Mierswa <impulze at impulze.org> schrieb:
> Hi list,
> because configure sets LDFLAGS=libz.a it could happen that the shared
                         ^^^^^^^^^^^^^^
Of course, that is crap ;-p

The bug is in configure:21 (in v1.2.5H) - simply remove that line (LDFLAGS=...)

If the test programs (eg. example, minigzip, ...) should be linked
statically, their appropriate make targets have to be fixed to use
the static library instead the shared one.

> --- ./Makefile.in.orig	2011-02-01 16:52:28.000000000 +0100
> +++ ./Makefile.in	2011-02-01 16:52:43.000000000 +0100
> @@ -136,7 +136,7 @@
>  	$(CC) $(SFLAGS) -DPIC -c -o objs/$*.o $<
>  	- at mv objs/$*.o $@
>0  
> -$(SHAREDLIBV): $(PIC_OBJS)
> +$(SHAREDLIBV): $(PIC_OBJS) $(STATICLIB)
>  	$(LDSHARED) $(SFLAGS) -o $@ $(PIC_OBJS) $(LDSHAREDLIBC) $(LDFLAGS)
>  	rm -f $(SHAREDLIB) $(SHAREDLIBM)
>  	ln -s $@ $(SHAREDLIB)

NAK. This only causes libz.a be built before the .so one, but
they're completely orthogonal (dont need each other whatsoever)
and might give funny results when building w/o the static one.


cu
-- 
----------------------------------------------------------------------
 Enrico Weigelt, metux IT service -- http://www.metux.de/

 phone:  +49 36207 519931  email: weigelt at metux.de
 mobile: +49 151 27565287  icq:   210169427         skype: nekrad666
----------------------------------------------------------------------
 Embedded-Linux / Portierung / Opensource-QM / Verteilte Systeme
----------------------------------------------------------------------




More information about the Zlib-devel mailing list