[Zlib-devel] [PATCH] 1.2.3 makefile.msc usability & rc fix (too late)

[William A. Rowe, Jr.]

Andrei Polushin wrote:
> William A. Rowe, Jr. wrote:
> 
>>Cosmin Truta wrote:
>>
>>>The right way to do it is by inserting the following lines in
>>>zconf.h.
>>>#    define _CRT_SECURE_NO_DEPRECATE
>>
>>+1 to that alternative to -wd4996 - I was deliberately avoiding any
>>source file pollution in this patch.  For the next release your
>>suggestion is quite sound and prefereable, actually.
> 
> There should be -D_CRT_SECURE_NO_DEPRECATE instead of -wd4996

Not with Cosmin's suggestion; his patch makes it unnecessary, which is why
I +1'ed (agreed with) his alternative.  SECURE is only half the battle, the
other half is NONSTDC (the utter bullshit of deprecating POSIX).

>>>>Generating the zlib1.pdb file does *not* affect the zlib1.dll in any
>>>>way (although the /debug flags lead people to believe it does.)
> 
> Moreover, zlib1.pdb should be available for download in addition to the
> corresponding binaries.

+1 - yes that's my point.  When you build a .dll - it's bound to the .pdb
that it emitted.  Generating a .pdb later isn't helpful, you need the one
that was generated by the official build.

Bill