[Zlib-devel] [PATCH] 1.2.3 makefile.msc usability & rc fix (too late)

[Andrei Polushin]

William A. Rowe, Jr. wrote:
> Cosmin Truta wrote:
>> William A. Rowe, Jr. wrote:
>>> I'd love for this patch to be considered.  It's a wee bit noisy
>>> (spewing various warnings that -wd4996 isn't known to the oldest
>>> vc 5/6 compilers) but with no ill side effects. That flag shuts
>>> down all the obnoxious VisualStudio 2005 noise about posix api's
>>> "deprecated" for ISO/C++ api's (utter bullshit).
>> [...]
>> The right way to do it is by inserting the following lines in
>> zconf.h.
>> #    define _CRT_SECURE_NO_DEPRECATE
> +1 to that alternative to -wd4996 - I was deliberately avoiding any
> source file pollution in this patch.  For the next release your
> suggestion is quite sound and prefereable, actually.

There should be -D_CRT_SECURE_NO_DEPRECATE instead of -wd4996


>>> Generating the zlib1.pdb file does *not* affect the zlib1.dll in any
>>> way (although the /debug flags lead people to believe it does.)

Moreover, zlib1.pdb should be available for download in addition to the
corresponding binaries.


--
Andrei Polushin