[Zlib-devel] patchzl120a.zip : new modification to zlib

[Cosmin Truta]

On Fri, 14 Mar 2003, Gilles Vollant wrote:

> I've uploaded to http://www.winimage.com/zLibDll/patchzl120a.zip new
> modification to zLib :
> - a zconf.h with suggestion in this list about vsnprintf
> - minizip.c and miniunz.c without exit(#) in main


Thanks. I have the following observations to make:

- There are .obj files inside patchzl120a.zip. I think it's a good idea
to keep "text only" files, at least inside the standard distribution.

- The indentation looked weird to me, until I realized that it's Visual
Studio who is responsible for this mess. Specifically, by default, the
tab size is set to 4, and the source files contain tabs. They look ok
inside VStudio, obviously, but they look terrible in any other text
editor. Please remove all tabs, i.e. convert each tab to 4 spaces.
In general, it is a good idea for every VStudio user to switch off the
tabs in the options menu.

* A very good source of advices is the ZipPorts file from the zip/unzip
source distribution (found inside the proginfo/ dir). Specifically, the
issues above are addressed by the rules:
  (1) NO FEELTHY TABS
  (3) NO FEELTHY 8-BIT CHARS
You may probably ignore rules (2) and (5), but everything else is still
making sense. If you disagree, blame it on Greg ;)

- I see you removed the vacuous "exit(0)" in main(), but the comment
"return 0;  /* to avoid warning */" is still misleading. Just do
"return 0;" without anything else, because this is the way you should
do it anyway (and not just to avoid warnings).


Best regards,
Cosmin