[Zlib-devel] [PATCH 08/13] Adds SSE2 optimized hash shifting to fill_window.

[Mike Frysinger]

On Friday 29 November 2013 05:25:43 Jim Kukunas wrote:
> On Thu, Nov 28, 2013 at 02:01:22AM -0500, Mike Frysinger wrote:
> > On Monday 25 November 2013 17:21:44 Jim Kukunas wrote:
> > > --- a/Makefile.in
> > > +++ b/Makefile.in
> > > 
> > > +fill_window_sse.lo: fill_window_sse.c
> > > +	- at mkdir objs 2>/dev/null || test -d objs
> > > +	$(CC) $(SFLAGS) -msse2 -DPIC -c -o objs/$*.o $<
> > > +	- at mv objs/$*.o $@
> > 
> > what is with the objs subdir ?  am i misreading or is this only for 1
> > file so the indirection is pointless ?  also silently ignoring errors
> > from that seems like a really bad idea.
> 
> These rules are copied verbatim from existing targets. The only
> difference is the added -msse2 for this target, and the -mpclmul -msse4 for
> the target in the next patch.

sounds like existing rules are broken and should be fixed rather than 
duplicated

> > i thought $* was for implicit rules which this is not.  so really you're
> > writing the output to "objs/.o".
> 
> $* works for explicit rules, so long as the suffix is a recognized one.
> .c is a recognized suffix, so this rule works as expected.

are you sure ?

$ cat Makefile 
fill_window_sse.lo: fill_window_sse.c
	echo $*.o
$ touch fill_window_sse.c
$ make
echo .o
.o
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://madler.net/pipermail/zlib-devel_madler.net/attachments/20131129/0f1a00fd/attachment-0001.sig>