[Zlib-devel] [PATCH 08/13] Adds SSE2 optimized hash shifting to fill_window.

[Mike Frysinger]

On Monday 25 November 2013 17:21:44 Jim Kukunas wrote:
> --- a/Makefile.in
> +++ b/Makefile.in
> 
> +fill_window_sse.lo: fill_window_sse.c
> +	- at mkdir objs 2>/dev/null || test -d objs
> +	$(CC) $(SFLAGS) -msse2 -DPIC -c -o objs/$*.o $<
> +	- at mv objs/$*.o $@

what is with the objs subdir ?  am i misreading or is this only for 1 file so 
the indirection is pointless ?  also silently ignoring errors from that seems 
like a really bad idea.

i thought $* was for implicit rules which this is not.  so really you're 
writing the output to "objs/.o".

> +fill_window_sse.o: fill_window_sse.c
> +	${CC} ${CFLAGS} -msse2 -I. -c -o $@ fill_window_sse.c

use $(...) rather than ${...}

any reason you don't use $< here ?
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://madler.net/pipermail/zlib-devel_madler.net/attachments/20131128/72bfbcdb/attachment-0001.sig>