[Zlib-devel] zlib 1.2.6.1

[Török Edwin]

On 02/19/2012 11:46 PM, Frédéric Kayser wrote:
> Thank you Mark,
> It compiles without a hitch, incidentally have you noticed that the patch removes "&& !defined(NO_VIZ)" from the test, is this intended?
> https://github.com/madler/zlib/commit/a75d6ea070cedd3afa9865e63127c7ee8946d605
> 
> Best regards
> Frédéric Kayser
> 
> ----- Mail original -----
> De: "Mark Adler" <madler at madler.net>
> À: zlib-devel at zlib.net
> Envoyé: Dimanche 19 Février 2012 00:39:45
> Objet: Re: [Zlib-devel] zlib 1.2.6.1
> 
> Frédéric,
> 
> Thanks for the testing.
> 
> On Feb 14, 2012, at 7:13 AM, Frédéric Kayser wrote:
>> Visibility support is set to yes since the configure script did not catch the warning,
> 
> Everyone kept saying, "don't check the output in configure, check the return code".  Sigh.
> 
> Anyway, I think I have fixed this by requiring gcc 4.0 or later when __APPLE__ is defined in order to use the visibility attribute.

Maybe try -Werror on this configure check, thats what visibility.m4 does from gettext.
Or just use that m4 macro from gettext.

--Edwin