[Zlib-devel] zlib 1.2.6.1

[Frédéric Kayser]

Hello,
compiled and tested OK on Mac OS X 10.3.9 PowerPC, GCC 2.95, 3.1 & 3.3
but there's a problem regarding the visibility attribute support in the configure file when using GCC 3.3 or 2.95, here is what I get in configure.log:

=== ztest12890.c ===
#if ((__GNUC__-0) * 10 + __GNUC_MINOR__-0 >= 33)
#  define ZLIB_INTERNAL __attribute__((visibility ("hidden")))
#else
#  define ZLIB_INTERNAL
#endif
int ZLIB_INTERNAL foo;
int main()
{
  return 0;
}
===
gcc -c -O3 ztest12890.c
ztest12890.c:11: warning: visibility attribute not supported in this configuration; ignored
Checking for attribute(visibility) support... Yes.

Visibility support is set to yes since the configure script did not catch the warning, functions defined as ZLIB_INTERNAL report the same warning during compilation, for instance:
inffast.c: In function `inflate_fast':
inffast.c:324: warning: visibility attribute not supported in this configuration; ignored

According to Apple documentation only GCC 4 supports visibility attributes this way:
https://developer.apple.com/library/mac/#documentation/developertools/Conceptual/CppRuntimeEnv/Articles/SymbolVisibility.html

GCC 3.1 does not trigger the problem since ZLIB_INTERNAL is defined empty in this case.
GCC 2.95 has the problem again, I suppose it comes from this:
(__GNUC__-0) * 10 + __GNUC_MINOR__-0 >= 33
Correct me if I'm wrong, but if run by GCC 2.95 isn't this going to be true since 2*10 + 95 = 115?
Found in configure and zutil.h

http://gcc.gnu.org/onlinedocs/cpp/Common-Predefined-Macros.html
Another approach is to use the predefined macros to calculate a single number, then compare that against a threshold:
#define GCC_VERSION (__GNUC__ * 10000 \
                     + __GNUC_MINOR__ * 100 \
                     + __GNUC_PATCHLEVEL__)
...
/* Test for GCC > 3.2.0 */
#if GCC_VERSION > 30200

Best regards
Frédéric Kayser

----- Mail original -----
De: "Mark Adler" <madler at madler.net>
À: "zlib developer list" <zlib-devel at zlib.net>
Envoyé: Lundi 13 Février 2012 00:17:04
Objet: [Zlib-devel] zlib 1.2.6.1

Faithful zlib testers,

zlib 1.2.6.1 is available for testing here:

    http://zlib.net/current/beta/zlib-1.2.6.1.tar.gz

This is a release candidate for zlib 1.2.7.  Please test it on whatever platforms you can, and report back the results.

Following Vincent's suggestion to keep a list of systems to test on before release, I requested information on the systems that you can test on.  I received one reply from Maarten.  The list so far is:

Adler - Mac OS X 10.6.8 with XCode 4.2 (clean compile and test)
Adler - Ubuntu 10.04 (clean compile and test)
Bosmans - Cross compiling from Linux for both win32 and win64 using gcc/mingw

If anyone would like to add to this list, please do.  Thank you for your support.

Mark



MD5 (zlib-1.2.6.1.tar.gz) = bbbf81501c37816fdb05e380742c4cea

SHA1(zlib-1.2.6.1.tar.gz)= d7812b15ee30e1fafadd7739ef211d3011d014f9

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (Darwin)

iD8DBQBPOD2VeD/Njli8r7oRAjVfAKCxkkkBX2fGdvK9OybarGTaVUMZUQCdH+z/
frvABS3BLeg74UgnRWL2SdI=
=fx+V
-----END PGP SIGNATURE-----


_______________________________________________
Zlib-devel mailing list
Zlib-devel at madler.net
http://mail.madler.net/mailman/listinfo/zlib-devel_madler.net