[Zlib-devel] [PATCH] Move gzflags to zutil.c

jbowler at acm.org jbowler at acm.org
Wed Feb 1 12:47:51 EST 2012


I second that suggestion.  At present to build libpng with my prior Visual Studio project I have to add:

#define gzflags() 0

In a pre-include file; otherwise the build pulls in gzwrite.obj, which needs gz_error, which pulls in gzlib.obj, yet nothing is used from this object modules except gzflags().

I did try Z_SOLO; this almost worked, but it causes a non-ANSI compliant declaration of ptrdiff_t to be made in zutil.h.

John Bowler <jbowler at acm.org>

-----Original Message-----
From: zlib-devel-bounces at madler.net [mailto:zlib-devel-bounces at madler.net] On Behalf Of Xin LI
Sent: Wednesday, February 01, 2012 12:27 AM
To: zlib-devel at zlib.net
Subject: [Zlib-devel] [PATCH] Move gzflags to zutil.c

Hi,

I find it a little bit weird that gzflags() belongs to gzwrite.c.  Is there a reason behind this?  I'd like to propose the attached patch.

Cheers,
--
Xin LI <delphij at delphij.net> https://www.delphij.net/ FreeBSD - The Power to Serve! Live free or die





More information about the Zlib-devel mailing list