[Zlib-devel] [PATCH] One remaining Valgrind error

[Jan Seiffert]

2012/8/16 Jan Seiffert <kaffeemonster at googlemail.com>:
> Daniel Richard G. schrieb:
[snip]
>> Here is an example of what I typically see. This is from a Valgrind
>> run on LibXML2's runtest program:
>>
>> Conditional jump or move depends on uninitialised value(s)
>>  ==631== at 0x5056510: inflateReset2 (in /lib/x86_64-linux-gnu/libz.so.1.2.3.4)
>
> And here we have the little bugger.
> But your patch was for deflateInit2_
> So call me confused.
>
> The only thing i see in infalteReset2 that may case this is that this:
>
> if (state->window != Z_NULL && state->wbits != (unsigned)windowBits)
>

Stop stop stop. Sorry.
You are using zlib version 1.2.3.4, where the conditional looks like this:

if (state->wbits != windowBits && state->window != Z_NULL)

So the uninit value is really tested, but it is moot.
It is changed in later versions (since 1.2.3.7) to shut up valgrind.

Greetings
Jan

-- 
˙qɐɥ ʇɟnɐʞǝƃ ʎɐqǝ ıǝq ɹnʇɐʇsɐʇ ǝuıǝ ɹıɯ ɥɔı sɐp lɐɯ ǝʇzʇǝl sɐp ʇsı sɐp
'ʇɯɯɐpɹǝʌ