[Zlib-devel] configure script

Maarten Bosmans mkbosmans at gmail.com
Sun Sep 18 15:56:38 EDT 2011


2011/9/17 Charles Wilson <cygwin at cwilson.fastmail.fm>:
> On 9/17/2011 11:46 AM, Mark Adler wrote:
>> On Sep 17, 2011, at 7:39 AM, Enrico Weigelt wrote:
>>> BTW: the autogenerated files (Makefile and zlib.h) should be
>>> removed from the repository.
>>
>> You mean zconf.h.
>>
>> The Makefile that's there just says "Please use ./configure first.  Thank you." when you run it.  I plan to leave that there.
>>
>> I suppose I could remove zconf.h.  It just seems odd to me to not have a full complement of source files.  Does it hurt something to leave it there?
>
> Yes.  If you build "out of tree" then sometimes the "old" one in the src
> directory takes priority over the new one, generated in the build dir
> (that is, when/if out-of-tree builds are supported by zlib's build system).
>
> Also, it means that every "git diff" reports "extra" changes to zconf.h
> -- which include whatever customized changes are necessary for the
> operator's current platform, but are not generally cross-platform in nature.

Furthermore, it requires you to keep in sync all the changes that go
into zlib.h.in with zlib.h. When you only released release source
tarballs, it wasn't such a problem to always run configure before
packaging, but now with git, it's not right to pull the latest master
and get an outdated zlib.h.

Maarten




More information about the Zlib-devel mailing list