[Zlib-devel] configure script

[Charles Wilson]

On 9/17/2011 11:46 AM, Mark Adler wrote:
> On Sep 17, 2011, at 7:39 AM, Enrico Weigelt wrote:
>> BTW: the autogenerated files (Makefile and zlib.h) should be
>> removed from the repository.
> 
> You mean zconf.h.
> 
> The Makefile that's there just says "Please use ./configure first.  Thank you." when you run it.  I plan to leave that there.
> 
> I suppose I could remove zconf.h.  It just seems odd to me to not have a full complement of source files.  Does it hurt something to leave it there?

Yes.  If you build "out of tree" then sometimes the "old" one in the src
directory takes priority over the new one, generated in the build dir
(that is, when/if out-of-tree builds are supported by zlib's build system).

Also, it means that every "git diff" reports "extra" changes to zconf.h
-- which include whatever customized changes are necessary for the
operator's current platform, but are not generally cross-platform in nature.

That is, all of my 'git diff' output reports a bunch of cygwin-specific
mods to zconf.h mixed in with intended to changes to non-auto-generated
files, and all of Bob's reports fedora-specific stuff.  Neither of us
can use 'git add -a' or 'git commit -a' because we need to exclude those
extraneous deltas.

Auto-generated files should not be included under source control.

--
Chuck