[Zlib-devel] Possible typo in zlib.h

[jbowler at acm.org]

From: İsmail Dönmez [mailto:ismail at namtrac.org] 
>So you mean ifdef is correct here?

 

I’m saying it *should* be correct in zlib-1.2.5 and *was not* correct in zlib-1.2.4.

 

However I think that in fact the patch never made it to 1.2.5; see this thread:

 

From: zlib-devel-bounces at madler.net [mailto:zlib-devel-bounces at madler.net] On Behalf Of Pierre Schmitz
Sent: Thursday, May 27, 2010 3:19 PM
To: zlib-devel at zlib.net
Subject: [Zlib-devel] zlib-1.2.5-lfs-decls.patch

 

So I think this patch (which is identical to what you suggest):

 

http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/sys-libs/zlib/files/zlib-1.2.5-lfs-decls.patch?view=markup

 

Still needs to be applied to 1.2.5

 

After examining the code I believe that zlib built on a 64-bit system with LFS64 support does not work unless the app defines _LARGEFILE64_SOURCE.  (That’s not a work-round, if the app defines that it changes all the header files.)

 

I run Gentoo, so my 1.2.5 zlib.h does have the patch ;-)

 

John Bowler jbowler at acm.org

 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://madler.net/pipermail/zlib-devel_madler.net/attachments/20110625/2fd1dcaa/attachment.html>