[Zlib-devel] zlib-1.2.5.ebuild [WAS: zlib-1.2.5 configure script issues]

[Pierre Schmitz]

On Mon, 26 Apr 2010 13:33:19 -0700, "John Bowler"
<jbowler at frontiernet.net> wrote:
> I think something is very wrong with this in 1.2.5.  Here's what
happened
> to gseek in 1.2.4 zlib.h, note the '#ifndef _LARGEFILE64_SOURCE' line:
> ...
> And this, I believe, is why gentoo applied the apparently mistaken patch
-
> the fix, surely, is to put the magic 'n' back?
> 
> I don't, personally, think that the mapping to gzseek64 is correct if
> _LARGEFILE64_SOURCE is unset - I actually like the net effect of the
gentoo
> patch more - but I may be misunderstanding the semantics of setting
> _FILE_OFFSET_BITS and _LFS64_LARGEFILE without setting
_LARGEFILE64_SOURCE
> (I don't think the mapping should happen at all unless the including
code
> gets *everything* right.)

I just stumbled upon this problem; cgit fails to compile due to this issue
on i686 (x86_64 is fine). I wonder why this change was made in the first
place (a vcs with comments would come in handy here ;)) Maybe it was just a
typo; otherwise I wont feel that well with replacing ifdef with an ifndef.

Greetings,

Pierre

-- 
Pierre Schmitz, https://users.archlinux.de/~pierre