[Zlib-devel] zlib 1.2.4 released

[Vincent Torri]

On Fri, 12 Mar 2010, Mark Adler wrote:

> On Mar 12, 2010, at 3:16 PM, Vincent Torri wrote:
>> for example, line 321 of gzwrite.c :
>>
>> for (len = 0; len < state->in; len++)
>>
>> you compare here an int with a pointer.
>
> Thanks for spotting that!  That's a bug.  The compiler would have complained about that if that code had ever been compiled.

when configuring with those flags:

CFLAGS="-Wmissing-declarations -Wmissing-prototypes -Wredundant-decls -Wwrite-strings -Wcast-align" ./configure

vsnprintf and vsprintf are not detected (because of -Wmissing-prototypes). 
That's why the compiler displayed the warning

Btw, with those flags, there is also a warning about unlink:

minigzip.c:54: warning: redundant redeclaration of 'unlink'
/usr/include/unistd.h:806: note: previous declaration of 'unlink' was here

Vincent