[Zlib-devel] zlib-1.2.5.ebuild [WAS: zlib-1.2.5 configure script issues]

[Mark Adler]

On Apr 26, 2010, at 1:33 PM, John Bowler wrote:
> That all makes sense to me.  Now, here is 1.2.5 zlib.h; see how the #ifndef line has mysteriously changed into a #ifdef line:

John,

Yes, that is the error.  I have updated it.

> I don't, personally, think that the mapping to gzseek64 is correct if _LARGEFILE64_SOURCE is unset - I actually like the net effect of the gentoo patch more - but I may be misunderstanding the semantics of setting _FILE_OFFSET_BITS and _LFS64_LARGEFILE without setting _LARGEFILE64_SOURCE (I don't think the mapping should happen at all unless the including code gets *everything* right.)

The standard usage is to simply set _FILE_OFFSET_BITS to 64, so the code does in fact need to do the mapping in that case (when _LARGEFILE64_SOURCE is not defined).

Mark