[Zlib-devel] metux 1.2.3.7

Enrico Weigelt weigelt at metux.de
Sat Jan 30 09:23:59 EST 2010


Dmitry V. Levin wrote:

> "Fixed zconf.h creation" -- one part of the patch seems redundant, because
> configure:247 already does that.  

Okay, overlooked it.

> "(gentoo) symbol visibility" -- this patch is odd (it does a visibility
> test twice).  It also looks redundant due to --version-script support.

Ok.

> "Fixed configure script not to break on -Werror" -- this one is good,
> it fixes configure for the case when CFLAGS contains e.g. -Wwrite-strings.

Yep, for my build systems it actually necessary (as I'm always building
w/ -Werror). IMHO, warnings should always be treated as errors.


cu
-- 
----------------------------------------------------------------------
 Enrico Weigelt, metux IT service -- http://www.metux.de/

 cellphone: +49 174 7066481   email: info at metux.de   skype: nekrad666
----------------------------------------------------------------------
 Embedded-Linux / Portierung / Opensource-QM / Verteilte Systeme
----------------------------------------------------------------------





More information about the Zlib-devel mailing list