[Zlib-devel] zlib 1.2.4.4 -- a 1.2.5 release candidate

[Török Edwin]

On 04/18/2010 12:11 PM, Arkadiusz Miskiewicz wrote:
> On Sunday 18 of April 2010, Mark Adler wrote:
>> Faithful testers,
>>
>> You can find zlib 1.2.4.4 here:
>>
>>      http://zlib.net/current/beta/zlib-1.2.4.4.tar.gz
>>
>> It is candidate for the 1.2.5 version.  Due to bugs in 1.2.4, I would like
>> to get 1.2.5 out within a few days, so I will only be making essential
>> changes to get to 1.2.5.
>
> x86_64-pld-linux-gcc -D_REENTRANT -D_FORTIFY_SOURCE=2  -O2 -fno-strict-
> aliasing -fwrapv -march=x86-64 -gdwarf-2 -g2  -DASMV -fPIC -
> D_LARGEFILE64_SOURCE=1 -fvisibility=hidden -DPIC -c -o objs/compress.o
> compress.c
> mkdir: cannot create directory `objs': File exists
> make: [adler32.lo] Error 1 (ignored)
>
> parallel build seems to be broken now

Same here, Debian unstable/x86_64.

>
> What's more broken is that build process is not failing on error.
>

No, its designed to ignore this error, the corresponding line in the 
Makefile has a leading '-@'. It shouldn't spam the error to the user though.

How about this patch (silences the mkdir failure, since there is an 
inherent race condition between the if and mkdir):
--- orig/Makefile.in    2010-04-18 09:43:58.000000000 +0300
+++ new/Makefile.in 2010-04-18 13:37:47.000000000 +0300
@@ -132,7 +132,7 @@
  .SUFFIXES: .lo

  .c.lo:
-       - at if [ ! -d objs ]; then mkdir objs; fi
+       - at if [ ! -d objs ]; then mkdir -p objs; fi
         $(CC) $(SFLAGS) -DPIC -c -o objs/$*.o $<
         - at mv objs/$*.o $@

Best regards,
--Edwin

Best regards,
--Edwin