[Zlib-devel] [PATCH] Check on _LARGEFILE64_SOURCE and friends are too strict

[Xin LI]

Hi,

It seems that now zlib wants to check whether _LARGEFILE64_SOURCE is
1, instead of testing whether it is defined.  This would be too strict
and at least GNU libc's manual says these macros are supposed to be
"defined" rather than a value.

The attached patch would fix this issue.

(I personally still prefer the approach I have taken, basically,
define ZLIB_LARGEFILE64_SOURCE in zconf.h based on
_LARGEFILE64_SOURCE, and OS, etc., while only test ZLIB_* macros in
other .h files.  If this sounds like a sensible approach I will work
out another patchset to implement that for your review).

Thanks in advance!

Cheers,
-- 
Xin LI <delphij at delphij.net> http://www.delphij.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: zlib.diff
Type: application/octet-stream
Size: 4163 bytes
Desc: not available
URL: <http://madler.net/pipermail/zlib-devel_madler.net/attachments/20100401/3e42f46b/attachment.obj>