[Zlib-devel] Zlib-1.2.4?

[Dan Nicholson]

On Wed, Aug 08, 2007 at 11:51:24PM -0400, Mark Adler wrote:
> On Aug 8, 2007, at 9:29 AM, Dan Nicholson wrote:
> > Is there anything holding this back from a 1.2.4
> > stable release?
> 
> Well, there is an unresolved problem with the configure shell script  
> syntax on a Sun running NetBSD that Nelson Beebe's comprehensive  
> testing found:
> 
> > Machinetype:            Sun W40z (4 CPUs, 2400 MHz AMD64 Opteron,  
> > 8GB RAM); NetBSD 1.6 (GENERIC)
> > Remote gcc version:     gcc (GCC) 3.4.3
> > Configure environment:  CC=gcc CXX=g++ LDFLAGS=-Wl,-rpath,/usr/ 
> > local/lib
> >
> > ./configure: 84: Syntax error: ";;" unexpected (expecting "fi")
> > Command exited with non-zero status 2
> 
> I haven't figured this out.
> 
> Maybe that's not enough to hold up a release.

I'm didn't see the same error, but it did bomb at roughly the same spot
using the shell from OpenSolaris. Many shells have trouble with empty
arguments to `test', so it's safer to quote variables. Patch below solved
the issue for me. I'll take a peek through and see if anything else jumps
out.

--
Dan

--- zlib-1.2.3.3/configure.orig	2007-08-08 22:30:25.000000000 -0700
+++ zlib-1.2.3.3/configure	2007-08-08 22:30:38.000000000 -0700
@@ -82,7 +82,7 @@ if test "$gcc" -eq 1 && ($cc -c $cflags 
   CC="$cc"
   SFLAGS="${CFLAGS-"-O3"} -fPIC"
   CFLAGS="${CFLAGS-"-O3"}"
-  if test -z $uname; then
+  if test -z "$uname"; then
     uname=`(uname -s || echo unknown) 2>/dev/null`
   fi
   case "$uname" in