[Zlib-devel] zlib-1.2.3-cos1

[Austin Ziegler]

On 5/15/06, Cosmin Truta <cosmin at cs.toronto.edu> wrote:
> - Shut up annoying VS2005 warnings about standard C deprecation [Rowe, Truta]
> - Swap the order of #include <stdio.h> and #include "zlib.h" in
>   gzio.c, example.c and minigzip.c [Truta]
>
> Both of these changes are here because much of the standard C library
> is "deprecated" in Visual C++ 8.
> Andrei Polushin made a point that the modification in zconf.h has side
> effects, and it's better to resort to using macros in VC makefiles and
> project files.
> His point is valid indeed, but I regard that as a "feature" rather than
> a "side effect". I mean, since zlib inherently depends on the standard
> C library, and the latter gets "deprecated", it implies the former also
> should be "deprecated" until that dependency is removed. Which (I bet)
> won't happen. zlib demands standard C, and anyone who demands zlib
> should also demand standard C.
> There's also the cosmetic point of putting all compiler and library
> hacks in zconf.h instead of scattering them across makefiles. And then
> there's the practical point that the change is done in one place
> (zconf.h) instead of synchronizing changes in win32/makefile.msc,
> projects/visualc, contrib/minizip, ... and any other makefiles and
> projects. Not to mention the possibility of getting them yet again out
> of sync.

I would far prefer *not* having this in an include file, because in my
workplace we currently use a statically built zlib and this would have
negative effects as far as I'm concerned.

I think that this is something that belongs to the makefile, not the
include file.

-austin
-- 
Austin Ziegler * halostatue at gmail.com
               * Alternate: austin at halostatue.ca