[Zlib-devel] zlib-1.2.3-cos1

[William A. Rowe, Jr.]

Cosmin Truta wrote:
> 
> - Add ZLIB_VER_MAJOR, ZLIB_VER_MINOR and ZLIB_VER_REVISION in zlib.h,
>   for use in win32/zlib1.rc [Polushin, Rowe, Truta]
> 
>   #define ZLIB_VERSION        "1.2.3-cos1"
>   #define ZLIB_VERNUM         0x123f
>   #define ZLIB_VER_MAJOR      1
>   #define ZLIB_VER_MINOR      2
>   #define ZLIB_VER_REVISION   3

Cosmin, you omitted ZLIB_VER_BUILD (fourth-level numeric signature).

It's TBD if this should be always included in the text representation.

I think it's VERY unhealth to propogate 'modify the version in three places',
you retain this behavior unless the net VERNUM and VERSION are computed.

I strongly advise against shorting this facility the very errors it's ment
to avert.

/> **
> 
> - Clean up compilation under Solaris SunStudio cc [Rowe]
> 
> As per the original submission.

TY.

> **
> 
/> - Create .pdb and .manifest files in win32/makefile.msc [Ziegler, Rowe]
> 
> As per the original submissions.

We did resolve manifest and .pdb creation, but one other flag, -Oy- was in
dispute.  Argument pro: stack traces, w/w-o a .pdb file can be unwound.
Argument con: building stacks would be a small performance hit.  Is this
incorporated or rejected?