[Zlib-devel] [PATCH] 1.2.3 makefile.msc usability & rc fix (too late)

[William A. Rowe, Jr.]

I've closed the issue of .manifests, generated .pdb debugging for release
zlib1.dll binary and corrected the .rc (you left it 1,2,2,0 in the last release)

http://www.apache.org/dist/httpd/binaries/win32/patches_applied/zlib-1.2.3-vc32-2005-rcver.patch

I'd love for this patch to be considered.  It's a wee bit noisy (spewing various
warnings that -wd4996 isn't known to the oldest vc 5/6 compilers) but with no
ill side effects.  That flag shuts down all the obnoxious VisualStudio 2005
noise about posix api's "deprecated" for ISO/C++ api's (utter bullshit).

Generating the zlib1.pdb file does *not* affect the zlib1.dll in any way
(although the /debug flags lead people to believe it does.)  All of the magic
is entirely contained in the zlib1.pdb, with the exception of a reference to
this file from zlib1.dll.  It's still just as optimized and efficient.  The
/Oy- makes stack backtraces without the .pdb file possible to follow, that does
slow things down just a bit.

The only other bit then is to use mt to fold the .manifests back into the .exe
and .dll, which this patch does, and to clean up .pdb and .manifest files on
nmake clean.

I've attached my zlib123-solaris patch to clean up zlib compilation under
solaris sunstudio cc, and emit some helpful noise when dynamic library
generation is refused.  This is just a reminder of my earlier post.

Patches attached for your consideration.

Bill



-------------- next part --------------
A non-text attachment was scrubbed...
Name: zlib123-solaris.patch
Type: text/x-patch
Size: 1247 bytes
Desc: not available
URL: <http://madler.net/pipermail/zlib-devel_madler.net/attachments/20060501/d8c32fbb/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: zlib-1.2.3-vc32-2005-rcver.patch
Type: text/x-patch
Size: 2144 bytes
Desc: not available
URL: <http://madler.net/pipermail/zlib-devel_madler.net/attachments/20060501/d8c32fbb/attachment-0001.bin>