[Zlib-devel] zlib-1.2.3-cos4

[William A. Rowe, Jr.]

Mark Adler wrote:
> On Aug 20, 2006, at 1:43 PM, William A. Rowe, Jr. wrote:
>> as long as it matches the zlib*.h pattern I'd think it's safe.
> 
> Oops.  The current zconf.h doesn't match that.  Should it be changed  
> to zlibconf.h?  The new .h file would be called zlibdefs.h.

I'd agree that zconf.h would be better named zlibconf.h but ... I don't
think it's worth changing midstream in a 1.1 or 1.2 point bump.  Save that
reorganization for a 1.3 or 2.0 bump :)  It hasn't hurt anyone so far as
I've heard of.

>> We use some symbols defined in zutil.h currently, for the OS flags, so
>> I already leverage that header (worse, if not found we declare the  
>> constants
>> ourselves ;-/ ).  If these can be public that would be great.
> 
> Let me know what symbols those are and what the application is.  Is  
> it just OS_CODE?

Yes... actually the current logic is reduced to...

static const char gzip_header[10] =
{ '\037', '\213', Z_DEFLATED, 0,
  0, 0, 0, 0, /* mtime */
  0, 0x03 /* Unix OS_CODE */
};

But I wonder how many others would find introspecting files using some
of the more interesting constants in zutil.h, to reasonably useful?