[Zlib-devel] ASM problem under Visual Studio 2005

[Gilles Vollant]

Probably the patch I submitted somes month ago

-----Original Message-----
From: Gilles Vollant [mailto:info at winimage.com] 
Sent: Friday, April 28, 2006 8:37 PM
To: 'Cosmin Truta'
Cc: 'timvanwassenhove at gmail.com'
Subject: FW: [Zlib-devel] Fwd: Compiling error in Visual Studio 2005

 

-----Original Message-----
From: Gilles Vollant [mailto:info at winimage.com]
Sent: Tuesday, November 15, 2005 4:22 PM
To: zlib-devel at zlib.net
Subject: Re: [Zlib-devel] Fwd: Compiling error in Visual Studio 2005

The modifed syntax is well on both old and new ML.exe

*** inffas32.asm        Sun Feb 06 12:44:59 2005
--- r:\image\inffas32a.asm      Tue Nov 15 16:19:33 2005
***************
*** 644,652 ****
        movd mm0,ebp
        mov  ebp,ebx
  ; 896 "inffast.S"
!       movd mm4,[esp+0]
        movq mm3,mm4
!       movd mm5,[esp+4]
        movq mm2,mm5
        pxor mm1,mm1
        mov  ebx, [esp+8]
--- 644,652 ----
        movd mm0,ebp
        mov  ebp,ebx
  ; 896 "inffast.S"
!       movd mm4, dword ptr [esp+0]
        movq mm3,mm4
!       movd mm5, dword ptr [esp+4]
        movq mm2,mm5
        pxor mm1,mm1
        mov  ebx, [esp+8]
***************
*** 660,666 ****
        ja  L_get_length_code_mmx

        movd mm6,ebp
!       movd mm7,[esi]
        add  esi,4
        psllq mm7,mm6
        add  ebp,32
--- 660,666 ----
        ja  L_get_length_code_mmx

        movd mm6,ebp
!       movd mm7,dword ptr [esi]
        add  esi,4
        psllq mm7,mm6
        add  ebp,32
***************
*** 717,723 ****
        ja L_get_dist_code_mmx

        movd mm6,ebp
!       movd mm7,[esi]
        add  esi,4
        psllq mm7,mm6
        add  ebp,32
--- 717,723 ----
        ja L_get_dist_code_mmx

        movd mm6,ebp
!       movd mm7,dword ptr [esi]
        add  esi,4
        psllq mm7,mm6
        add  ebp,32 

-----Original Message-----
From: Shane Baker [mailto:sbaker at xtier.com]
Sent: Tuesday, November 15, 2005 6:51 AM
To: zlib-devel at zlib.net
Subject: Re: [Zlib-devel] Fwd: Compiling error in Visual Studio 2005

The following suggests that the VS 2003 assembler accepted invalid syntax.
I did modify the syntax as the link suggests and run through the 2003
assembler, but I did not test the results.

http://www.virtualdub.org/blog/pivot/entry.php?id=9

http://lab.msdn.microsoft.com/productfeedback/viewfeedback.aspx?feedbackid=6
306f7dc-2cc2-4591-bd60-5d802178fdfa

Shane

On Mon, 14 Nov 2005, Mark Adler wrote:

> Anyone know why?
>
> mark
>
>
> Begin forwarded message:
> > From: Catalin Rotaru <catalin.rotaru at gmail.com>
> > Date: November 14, 2005 6:10:33 AM PST
> > To: zlib at gzip.org
> > Subject: Compiling error in Visual Studio 2005
> >
> > I can't seem to be able to compile zlib 1.2.3 on Visual Studio 2005.
> > Works just fine on 2003 though.
> > Here's the log:
> >
> >
> > Assembling...
> >
> > Assembling: d:\Temp\TestAI\zlib\contrib\masmx86\inffas32.asm
> > d:\Temp\TestAI\zlib\contrib\masmx86\inffas32.asm(647) : error A2070:
> > invalid instruction operands
> > d:\Temp\TestAI\zlib\contrib\masmx86\inffas32.asm(649) : error A2070:
> > invalid instruction operands
> > d:\Temp\TestAI\zlib\contrib\masmx86\inffas32.asm(663) : error A2070:
> > invalid instruction operands
> > d:\Temp\TestAI\zlib\contrib\masmx86\inffas32.asm(720) : error A2070:
> > invalid instruction operands
> >
> > Project : error PRJ0019: A tool returned an error code from 
> > "Assembling..."
> >
> > Any ideas?

----------------------------------------------------------------------------
------------------------------------------------------------------------ 

-----Original Message-----
From: Cosmin Truta [mailto:cosmin at cs.toronto.edu] 
Sent: Friday, April 28, 2006 8:21 PM
To: Zlib-devel at zlib.net
Cc: timvanwassenhove at gmail.com
Subject: [Zlib-devel] ASM problem under Visual Studio 2005


Hi,

I received the following message a few days ago. I tried to understand
what's wrong with the current code, but I couldn't. Would the ASM gurus
please have a look at it?

Best regards,
Cosmin


---------- Forwarded message ----------
Date: Sat, 15 Apr 2006 02:25:05 -0400
From: Tim Van Wassenhove
To: Cosmin Truta
Subject: Compiling zlib with Visual Studio 2005

Hello,

Yesterday i tried to compile zlib-1.2.3 with Visual Studio 2005 (the zlib
project) The compiler complained about a couple of "invalid syntax" errors.
I've searched the web, and discovered an articel on MSDN KB that explained
what was going on.

I've editted contrib/masmx86/inffas32.asm in order to make it work.

line 647: 	movd mm4,dword ptr[esp+0]
line 649:	movd mm5,dword ptr[esp+4]
line 663:	movd mm7,dword ptr[esi]
line 720:	movd mm7,dword ptr[esi]

I couldn't find this anywhere in the documentation so i thought this might
be useful information.


--
Don't applaud, throw money (paypal: timvw at users.sourceforge.net) Website @
http://timvw.madoka.be

_______________________________________________
Zlib-devel mailing list
Zlib-devel at zlib.net
http://madler.net/mailman/listinfo/zlib-devel_madler.net