[Zlib-devel] Updates to zlib 1.2.0.3 - pick one

[Gilles Vollant]

I tested the Cosmin work.
For me zlib-1.2.0.f-cos0 is good, zlib-1.2.0.f-cos1 break my project.

There is two option :
a) zlib-1.2.0.f-cos0 as is.
b) modified zlib-1.2.0.f-cos1 with explicit ZLIB_DLL_STDCALL (or simple
ZLIB_STDCALL) define

b) in an option that compile always in CDECL way, except if we define
anything explicit like ZLIB_DLL_STDCALL. I can ask user of my DLL define
ZLIB_DLL_STDCALL instead ZLIB_DLL in their project (but nothing more
complex, please), and ZLIB_DLL_STDCALL will never disturb anyone that don't
want STDCALL

For compatibility, I'll continue build a DLL that use WINAPI/STDCALL and zip
function.
If noone never made a DLL with WINAPI/STDCALL, Visual Basic (by example)
user will never be able use zlib

<<
- The DEF file used to build ZLIB.DLL includes unofficial exports.
  You can either fix the DEF file, or use a name different than
  "ZLIB.DLL" or "ZLIB1.DLL" for the compiled DLL.
>>
I'll not modify the .def.

If you think this is a big help, I can rename my DLL as zlibwapi.dll (by
example), to avoid confusion, by modifing contrib\vstudio\vc70_32\*.vcproj
and contrib\testzlib\*.vcproj
If one of my user want full compatibility, he will renance this dll as
zlib.dll, but we don't contribute to confusion.


<<
- The project requires a library file "crtdll.lib" that does not exist
  in that directory, and there is no doc indicating where to get it
  from.>>
This file is useful (allow don't include MS Runtime and use a DLL already
installed on all Win32 platform)
I suggest adding link to http://www.winimage.com/zLibDll/crtdll.lib in
contrib/vstudio/readme.txt
Note that the DLL project contain alredy target "ReleaseWithoutCrtDll"

About 6) in your FAQ, can I suggest you add link to
http://support.microsoft.com/?id=94248
(section 5, Mixing Library Types)


<<
- In zlib-...-cos1, the ASM interface is now unified with the rest of
  the sources compiled with CDECL. I think it's a good idea to adapt
  your ASM files and to put them into "contrib/asm686/", so that they
  can work like the rest, and are available to all the other makefiles.>>
Can you explain more what I need to modify in my assembly code to adapt.